New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/kv: do not return retryable error when tikv is closing #4146

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@overvenus
Copy link
Member

overvenus commented Jan 30, 2019

What have you changed? (mandatory)

This reverts commit 211d428 temporarily because it may cause Duplicate entry error in TiDB.

What are the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Manually

Does this PR affect documentation (docs) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Refer to a related PR or issue link (optional)

#3908

Do not retry when tikv is closing
This reverts commit 211d428.

Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus added the T: BugFix label Jan 30, 2019

@siddontang
Copy link
Contributor

siddontang left a comment

LGTM

@disksing

This comment has been minimized.

Copy link
Collaborator

disksing commented Jan 31, 2019

Do we need to include it in master too?

@zhangjinpeng1987 zhangjinpeng1987 merged commit c7cbff0 into tikv:release-2.1 Feb 2, 2019

2 checks passed

DCO All commits are signed off!
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details

@overvenus overvenus deleted the overvenus:release-2.1-revert-3908 branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment