github: require release note on pull requests #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the release note should be changed when release, instead of a single PR? |
|
@breeswish I think it's okay to change the changelog on PRs, some projects also do this, eg rocksdb. Collecting release note when release is sometimes annoying and we may forget to mention important changes. |
|
PTAL @dcalvin |
dcalvin
reviewed
Apr 24, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com> Update .github/pull_request_template.md Co-Authored-By: overvenus <overvenus@gmail.com> Update .github/pull_request_template.md Co-Authored-By: overvenus <overvenus@gmail.com> Signed-off-by: Neil Shen <overvenus@gmail.com>
|
PTAL, thanks! |
|
/run-unit-test |
|
/run-unit-test |
jswh
pushed a commit
to jswh/tikv
that referenced
this pull request
May 27, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com> Update .github/pull_request_template.md Co-Authored-By: overvenus <overvenus@gmail.com> Update .github/pull_request_template.md Co-Authored-By: overvenus <overvenus@gmail.com> Signed-off-by: Neil Shen <overvenus@gmail.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com> Update .github/pull_request_template.md Co-Authored-By: overvenus <overvenus@gmail.com> Update .github/pull_request_template.md Co-Authored-By: overvenus <overvenus@gmail.com> Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Require release note on pull requests if it should be mentioned.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
No.
Does this PR affect documentation (docs) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.