Add RPN function LTReal LEReal GTReal GEReal NEReal EQReal #4602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
|
/run-integration-tests |
|
A note for reviewers: This PR intentionally does not have comments. The comments will be added by @mapleFU later, as his task of understanding our code base. If you have any questions when understanding the PR, you can contact me privately :) |
|
/rebuild |
kennytm
reviewed
May 1, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
lonng
reviewed
May 5, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
|
/run-integration-tests |
|
LGTM |
jswh
pushed a commit
to jswh/tikv
that referenced
this pull request
May 27, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Extracted from #3898, this PR adds binary compare RPN functions for
Realdata type.What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Unit test & Integration test