Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix tick_after_destroy #4647

Merged
merged 4 commits into from
May 8, 2019
Merged

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented May 7, 2019

What have you changed? (mandatory)

raft 0.4.2 forbids follower with unapplied configuration change become
leader, so the test case can't work as before. This pr uses isolation
instead transferring leader to make it work again.

What are the type of the changes? (mandatory)

  • Bug fix

How has this PR been tested? (mandatory)

unit tests

Does this PR affect documentation (docs) or release note? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Refer to a related PR or issue link (optional)

#4637

raft 0.4.2 forbids follower with unapplied configuration change become
leader, so the test case can't work as before. This pr uses isolation
instead transferring leader to make it work again.

Signed-off-by: Jay Lee <busyjaylee@gmail.com>
@BusyJay BusyJay added sig/raft Component: Raft, RaftStore, etc. type/bugfix This PR fixes a bug. labels May 7, 2019
@hicqu
Copy link
Contributor

hicqu commented May 7, 2019

LGTM

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BusyJay
Copy link
Member Author

BusyJay commented May 8, 2019

/run-integration-tests

@BusyJay
Copy link
Member Author

BusyJay commented May 8, 2019

/run-integration-tests

@hicqu hicqu merged commit 79cdbc3 into tikv:master May 8, 2019
jswh pushed a commit to jswh/tikv that referenced this pull request May 27, 2019
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/raft Component: Raft, RaftStore, etc. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants