Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix tick_after_destroy #4647

Merged
merged 4 commits into from May 8, 2019

Conversation

Projects
None yet
3 participants
@BusyJay
Copy link
Contributor

commented May 7, 2019

What have you changed? (mandatory)

raft 0.4.2 forbids follower with unapplied configuration change become
leader, so the test case can't work as before. This pr uses isolation
instead transferring leader to make it work again.

What are the type of the changes? (mandatory)

  • Bug fix

How has this PR been tested? (mandatory)

unit tests

Does this PR affect documentation (docs) or release note? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Refer to a related PR or issue link (optional)

#4637

tests: fix tick_after_destroy
raft 0.4.2 forbids follower with unapplied configuration change become
leader, so the test case can't work as before. This pr uses isolation
instead transferring leader to make it work again.

Signed-off-by: Jay Lee <busyjaylee@gmail.com>
@hicqu

hicqu approved these changes May 7, 2019

@hicqu

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

LGTM

@Connor1996
Copy link
Member

left a comment

LGTM

@BusyJay

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

/run-integration-tests

@BusyJay

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

/run-integration-tests

@hicqu hicqu merged commit 79cdbc3 into tikv:master May 8, 2019

4 of 5 checks passed

idc-jenkins-ci-tikv/integration-common-test Jenkins job failed
Details
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.