readme: update readme logo's resolution #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calvin Weng <wenghao@pingcap.com>
Signed-off-by: Calvin Weng <wenghao@pingcap.com>
Signed-off-by: Calvin Weng <wenghao@pingcap.com>
Signed-off-by: Calvin Weng <wenghao@pingcap.com>
overvenus
reviewed
May 17, 2019
|
I also like our big obnoxious logo! |
|
@dcalvin It seems the new logo has a white background. Some folks use CSS skins to change how Github looks, do you think we could use a transparent background? |
breezewish
approved these changes
May 20, 2019
jswh
pushed a commit
to jswh/tikv
that referenced
this pull request
May 27, 2019
* update latest logo Signed-off-by: Calvin Weng <wenghao@pingcap.com> * reverse file permission to 644 Signed-off-by: Calvin Weng <wenghao@pingcap.com> * fix logo-too-big issue Signed-off-by: Calvin Weng <wenghao@pingcap.com> * update logo's resolution in readme Signed-off-by: Calvin Weng <wenghao@pingcap.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
* update latest logo Signed-off-by: Calvin Weng <wenghao@pingcap.com> * reverse file permission to 644 Signed-off-by: Calvin Weng <wenghao@pingcap.com> * fix logo-too-big issue Signed-off-by: Calvin Weng <wenghao@pingcap.com> * update logo's resolution in readme Signed-off-by: Calvin Weng <wenghao@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Please explain IN DETAIL what the changes are in this PR and why they are needed:
What are the type of the changes? (mandatory)
The currently defined types are listed below, please pick one of the types for this PR by removing the others: