Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate coprocessor statistics interfaces #5121

Merged
merged 6 commits into from
Jul 24, 2019

Conversation

breezewish
Copy link
Member

Signed-off-by: Breezewish breezewish@pingcap.com

What have you changed? (mandatory)

This PR separates Coprocessor metrics / statistics interfaces into two:

  • execution statistics, including scanned rows each range and execution summaries.
  • storage statistics, which is storage::Statistics.

The purpose is to isolate storage related statistics from the rest, for extracting the Coprocessor DAG.

This PR is extracted from #5119

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)

No need.

Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
@breezewish
Copy link
Member Author

/run-integration-tests

1 similar comment
@zyxbest
Copy link
Contributor

zyxbest commented Jul 23, 2019

/run-integration-tests

@lonng
Copy link
Member

lonng commented Jul 23, 2019

Rest LGTM

Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breezewish
Copy link
Member Author

/run-integration-tests

@breezewish breezewish merged commit 91a07bc into tikv:master Jul 24, 2019
@breezewish breezewish deleted the __cop_extract/3 branch July 24, 2019 02:59
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants