-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lock_manager: pass Config
when creates WaiterManager
and Detector
#5162
Merged
youjiali1995
merged 2 commits into
tikv:master
from
youjiali1995:pass-config-to-lock-manager
Jul 31, 2019
Merged
lock_manager: pass Config
when creates WaiterManager
and Detector
#5162
youjiali1995
merged 2 commits into
tikv:master
from
youjiali1995:pass-config-to-lock-manager
Jul 31, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
/test |
MyonKeminta
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AndreMouche
approved these changes
Jul 31, 2019
AndreMouche
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jul 31, 2019
/run-all-tests |
@youjiali1995 merge failed. |
youjiali1995
added a commit
to youjiali1995/tikv
that referenced
this pull request
Aug 5, 2019
…r` (tikv#5162) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
…r` (tikv#5162) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What have you changed? (mandatory)
Pass
Config
when createsWaiterManager
andDetector
to reduce parameters.What are the type of the changes? (mandatory)
Does this PR affect documentation (docs) or release note? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No