Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock_manager: pass Config when creates WaiterManager and Detector #5162

Merged
merged 2 commits into from
Jul 31, 2019

Conversation

youjiali1995
Copy link
Contributor

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What have you changed? (mandatory)

Pass Config when creates WaiterManager and Detector to reduce parameters.

What are the type of the changes? (mandatory)

  • Engineering (engineering change which doesn't change any feature or fix any issue)

Does this PR affect documentation (docs) or release note? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@MyonKeminta
Copy link
Contributor

/test

Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche AndreMouche added the status/can-merge Indicates a PR has been approved by a committer. label Jul 31, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 31, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 31, 2019

@youjiali1995 merge failed.

@youjiali1995 youjiali1995 merged commit 0d07088 into tikv:master Jul 31, 2019
@youjiali1995 youjiali1995 deleted the pass-config-to-lock-manager branch July 31, 2019 07:53
youjiali1995 added a commit to youjiali1995/tikv that referenced this pull request Aug 5, 2019
…r` (tikv#5162)

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
YangKeao added a commit to YangKeao/tikv that referenced this pull request Sep 5, 2019
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
…r` (tikv#5162)

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG: Transaction status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants