Cherry-pick check titandb directory when titan is disabled #5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added
component/titan
|
Please do not merge it until we release v3.0.5 |
|
/run-all-tests |
AndreMouche
reviewed
Oct 29, 2019
| let cache = self.cfg.storage.block_cache.build_shared_cache(); | ||
| let kv_db_opt = self.cfg.rocksdb.build_opt(); | ||
| let kv_cfs_opt = self.cfg.rocksdb.build_cf_opts(&cache); | ||
| let engine = Arc::new( | ||
| rocks::util::new_engine_opt(kv_path.to_str().unwrap(), kv_db_opt, kv_cfs_opt) | ||
| .unwrap(), | ||
| ); | ||
| let raft_path = dir.path().join(Path::new("raft")); | ||
| let raft_path = dir.path().join("raft"); |
There was a problem hiding this comment.
No difference, can remove the Path dependency now. And also more consistent.
yiwu-arbug
approved these changes
Oct 29, 2019
Connor1996
added
the
status/can-merge
|
Sorry @Connor1996, you don't have permission to trigger auto merge event on this branch. |
|
/run-all-tests |
|
/merge |
|
Your auto merge job has been accepted, waiting for 5895, 5918, 5913, 5863, 5929, 5923 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tabokie xy.tao@outlook.com
What have you changed?
Check titandb directory is empty (
ls *.blobcount = 0) when titan is disabled. Fatal panic if this check fails, which indicates titan is turned off before all blob files are merged.What is the type of the changes?
How is the PR tested?
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
Does this PR affect
tidb-ansible?Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)