storage: simple refactoring #5822
Conversation
nrc
requested review from
youjiali1995 and
breezewish
and removed request for
youjiali1995
nrc
added
component/storage
| @@ -21,18 +21,22 @@ use std::io::Error as IoError; | |||
| use std::sync::{atomic, Arc}; | |||
| use std::{cmp, error, u64}; | |||
|
|
|||
| use engine::{IterOption, DATA_KEY_PREFIX_LEN}; | |||
| use engine::{ | |||
There was a problem hiding this comment.
I saw it in the import formatting:
Group imports from the same logical project together (i.e., imports from different crates in the same project).
Group imports from external crates together; do not separate std imports from other crates.
engine crate is a component in TiKV. futures is an external crate. kvproto is a part of TiKV but in a different GitHub repo. Should we group them together?
There was a problem hiding this comment.
Oh, do you think they all belong to external crates? Only crate::.. is from the same logical project.
There was a problem hiding this comment.
I've been thinking about it since I was doing this PR :-) I think I will change that advice somewhat, it is complicated.
The grouping I;ve used here is to put the imports then the re-exports and group by std, external crates (including workspace crates), then the current crate
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
|
@youjiali1995 @MyonKeminta rebased and comments addressed. Please take another look |
|
Oh, something wrong in CI. Please fix the CI. |
Signed-off-by: Nick Cameron <nrc@ncameron.org>
youjiali1995
added
the
status/can-merge
|
/run-all-tests |
Signed-off-by: Nick Cameron <nrc@ncameron.org>
What have you changed?
These are mostly simple code motion refactorings to split up a few big files and get rid of some
utilsmodules.What is the type of the changes?
Pick one of the following and delete the others:
PTAL @breeswish @youjiali1995 (I recommend reviewing each commit, they standalone and each is quite simple by itself)