[release-3.0] cherry pick: add commit log duration metrics #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
|
/run-all-tests |
BusyJay
added
the
priority/release-blocker
BusyJay
reviewed
Nov 14, 2019
| if !ready.committed_entries.as_ref().map_or(true, Vec::is_empty) | ||
| && ctx.current_time.is_none() | ||
| { | ||
| ctx.current_time.replace(monotonic_raw_now()); |
There was a problem hiding this comment.
Why not initialize it at L1285?
There was a problem hiding this comment.
It look odd to initialize current_time here, but it based on a reason:
when there are proposal msg current_time will be initialize at L1650, and when there are not, initialize current_time here is more close to initialize at L1650 than L1285, as between here and L1650 there is no time consume work like send msg or write to disk.
src/raftstore/store/peer.rs
Outdated
| @@ -1275,6 +1281,9 @@ impl Peer { | |||
| if lease_to_be_updated { | |||
| let propose_time = self.find_propose_time(entry.get_index(), entry.get_term()); | |||
| if let Some(propose_time) = propose_time { | |||
| ctx.raft_metrics.commit_log.observe(duration_to_sec( | |||
There was a problem hiding this comment.
I think commit duration should be observed from the head instead of the tail.
There was a problem hiding this comment.
You are right, PTAL again.
Signed-off-by: linning <linningde25@gmail.com>
|
/run-all-tests |
overvenus
approved these changes
Nov 16, 2019
fredchenbj
pushed a commit
to fredchenbj/tikv
that referenced
this pull request
Dec 11, 2019
* cherry-pick: add commit log duration metrics Signed-off-by: linning <linningde25@gmail.com> * cherry pick: rename lease_time to current_time Signed-off-by: linning <linningde25@gmail.com> * observe first propose_time Signed-off-by: linning <linningde25@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed?
cherry-pick: #5440 #5465
What is the type of the changes?
How is the PR tested?
No
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect
tidb-ansible?pingcap/tidb-ansible#577