Implement the Diagnostics gRPC service #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <heng@lonng.org>
56 tasks
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
lonng
commented
Nov 21, 2019
| }; | ||
|
|
||
| let mut search_files = vec![]; | ||
| for entry in read_dir(log_dir)? { |
There was a problem hiding this comment.
For reviewer: This PR is temporarily implemented using synchronous IO, which will later refactor asynchronous IO (implemented by me or by community members). The reason is that we need to implement an asynchronous version of rev_lines dependency. Consider the modification of this PR is very huge, so split into two parts.
Signed-off-by: Lonng <heng@lonng.org>
overvenus
reviewed
Nov 22, 2019
Signed-off-by: Lonng <heng@lonng.org>
overvenus
previously approved these changes
Nov 25, 2019
hicqu
reviewed
Nov 25, 2019
hicqu
reviewed
Nov 25, 2019
Signed-off-by: Lonng <heng@lonng.org>
hicqu
approved these changes
Nov 25, 2019
overvenus
approved these changes
Nov 25, 2019
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
hawkingrei
pushed a commit
to hawkingrei/tikv
that referenced
this pull request
Dec 1, 2019
Signed-off-by: Lonng <heng@lonng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What have you changed?
Initial implementation of diagnostics log service, which is part of pingcap/tidb#13481
Known issue
This PR is implemented using synchronous IO and refactored to asynchronous IO in the next PR.
What is the type of the changes?
Pick one of the following and delete the others:
How is the PR tested?
Please select the tests that you ran to verify your changes: