Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Diagnostics gRPC service #5980

Merged
merged 12 commits into from Nov 25, 2019
Merged

Implement the Diagnostics gRPC service #5980

merged 12 commits into from Nov 25, 2019

Conversation

@lonng
Copy link
Contributor

lonng commented Nov 20, 2019

Signed-off-by: Lonng heng@lonng.org

What have you changed?

Initial implementation of diagnostics log service, which is part of pingcap/tidb#13481

Known issue

This PR is implemented using synchronous IO and refactored to asynchronous IO in the next PR.

What is the type of the changes?

Pick one of the following and delete the others:

  • New feature (a change which adds functionality)

How is the PR tested?

Please select the tests that you ran to verify your changes:

  • Unit test
  • Manual test (add detailed scripts or steps below)
Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng added the C: Server label Nov 20, 2019
@lonng lonng mentioned this pull request Nov 20, 2019
26 of 60 tasks complete
lonng added 3 commits Nov 21, 2019
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
};

let mut search_files = vec![];
for entry in read_dir(log_dir)? {

This comment has been minimized.

Copy link
@lonng

lonng Nov 21, 2019

Author Contributor

For reviewer: This PR is temporarily implemented using synchronous IO, which will later refactor asynchronous IO (implemented by me or by community members). The reason is that we need to implement an asynchronous version of rev_lines dependency. Consider the modification of this PR is very huge, so split into two parts.

@lonng lonng requested review from overvenus and hicqu Nov 21, 2019
lonng added 3 commits Nov 21, 2019
Signed-off-by: Lonng <heng@lonng.org>
lonng added 2 commits Nov 23, 2019
Signed-off-by: Lonng <heng@lonng.org>
lonng added 2 commits Nov 25, 2019
Signed-off-by: Lonng <heng@lonng.org>
@hicqu
hicqu approved these changes Nov 25, 2019
@lonng

This comment has been minimized.

Copy link
Contributor Author

lonng commented Nov 25, 2019

/merge

@sre-bot sre-bot added the S: CanMerge label Nov 25, 2019
@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Nov 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit c0d805d into tikv:master Nov 25, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-copr-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@lonng lonng deleted the lonng:diagnostics branch Nov 25, 2019
hawkingrei added a commit to hawkingrei/tikv that referenced this pull request Dec 1, 2019
Signed-off-by: Lonng <heng@lonng.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.