Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update grpc to fix a potencial memory leak issue #6128

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 2, 2019

Signed-off-by: qupeng qupeng@pingcap.com

What have you changed?

Update grpc to fix a potencial memory leak issue.

What is the type of the changes?

Engineering.

How is the PR tested?

Unit tests.

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No.

Does this PR affect tidb-ansible?

No.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Any examples? (optional)

Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu added the component/gRPC Component: gRPC label Dec 2, 2019
@hicqu
Copy link
Contributor Author

hicqu commented Dec 2, 2019

/bench

@overvenus overvenus added the type/cherry-pick Type: PR - Cherry pick label Dec 2, 2019
@hicqu
Copy link
Contributor Author

hicqu commented Dec 2, 2019

/merge

Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hicqu
Copy link
Contributor Author

hicqu commented Dec 3, 2019

/run-all-tests

@AndreMouche AndreMouche merged commit 8416da3 into tikv:release-3.0 Dec 3, 2019
@hicqu hicqu deleted the 3.0-update-grpc branch December 3, 2019 06:25
fredchenbj pushed a commit to fredchenbj/tikv that referenced this pull request Dec 11, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/gRPC Component: gRPC type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants