Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb_query: fix the logical behavior of floats #7342

Merged
merged 7 commits into from
Apr 21, 2020

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Apr 2, 2020

Signed-off-by: zhongzc zhongzc_arch@outlook.com

What problem does this PR solve?

See: pingcap/tidb#15927

What is changed and how it works?

Don't round the float value when converting it to bool.

@zhongzc
Copy link
Contributor Author

zhongzc commented Apr 2, 2020

/test

Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
@zhongzc

This comment has been minimized.

Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
@zhongzc
Copy link
Contributor Author

zhongzc commented Apr 20, 2020

/run-all-tests tidb=pr/15927

@zhongzc zhongzc requested a review from breezewish April 20, 2020 09:03
@zhongzc zhongzc added needs-cherry-pick-release-2.1 Need cherry pick to release 2.1 needs-cherry-pick-release-3.0 Type: Need cherry pick to release 3.0 needs-cherry-pick-release-3.1 Type: Need cherry pick to release 3.1 needs-cherry-pick-release-4.0 Type: Need cherry pick to release 4.0 labels Apr 20, 2020
@qw4990 qw4990 requested a review from lonng April 21, 2020 02:24
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT2 Status: PR - There are already 2 approvals label Apr 21, 2020
@zhongzc
Copy link
Contributor Author

zhongzc commented Apr 21, 2020

/merge

@sre-bot sre-bot added the status/can-merge Status: Can merge to base branch label Apr 21, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

@zhongzc merge failed.

@zhongzc
Copy link
Contributor Author

zhongzc commented Apr 21, 2020

/run-all-tests tidb=pr/15927

@zhongzc
Copy link
Contributor Author

zhongzc commented Apr 21, 2020

/run-integration-copr-test tidb=pr/15927

1 similar comment
@zhongzc
Copy link
Contributor Author

zhongzc commented Apr 21, 2020

/run-integration-copr-test tidb=pr/15927

@zhongzc
Copy link
Contributor Author

zhongzc commented Apr 21, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

@zhongzc merge failed.

@zhongzc zhongzc merged commit 6b60d57 into tikv:master Apr 21, 2020
sre-bot pushed a commit to sre-bot/tikv that referenced this pull request Apr 21, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

cherry pick to release-2.1 in PR #7580

sre-bot pushed a commit to sre-bot/tikv that referenced this pull request Apr 21, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

cherry pick to release-3.0 in PR #7581

sre-bot pushed a commit to sre-bot/tikv that referenced this pull request Apr 21, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

cherry pick to release-3.1 in PR #7582

sre-bot pushed a commit to sre-bot/tikv that referenced this pull request Apr 21, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

cherry pick to release-4.0 in PR #7583

zhongzc added a commit to sre-bot/tikv that referenced this pull request Apr 26, 2020
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
zhongzc added a commit to sre-bot/tikv that referenced this pull request Apr 26, 2020
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
zhongzc added a commit to sre-bot/tikv that referenced this pull request Apr 26, 2020
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
sre-bot added a commit that referenced this pull request Apr 28, 2020
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
sre-bot added a commit that referenced this pull request Apr 28, 2020
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
sre-bot added a commit that referenced this pull request Apr 30, 2020
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
c1ay pushed a commit to c1ay/tikv that referenced this pull request May 9, 2020
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
solotzg added a commit to pingcap/tidb-engine-ext that referenced this pull request May 14, 2020
txn: only wake up waiters when locks are indeed released (tikv#7379) (tikv#7585)

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

txn: don't protect rollback for BatchRollback (tikv#7605) (tikv#7608)

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

tidb_query: add is true/false keep null ScalarFuncSig (tikv#7532) (tikv#7566)

Signed-off-by: zhongzc <zhongzc_arch@outlook.com>

tidb_query: fix the logical behavior of floats (tikv#7342) (tikv#7582)

Signed-off-by: zhongzc <zhongzc_arch@outlook.com>

tidb_query: fix converting bytes to bool (tikv#7486) (tikv#7547)

Signed-off-by: zhongzc <zhongzc_arch@outlook.com>

raftstore: change the condition of proposing rollback merge (tikv#6584) (tikv#7762)

Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.1 Need cherry pick to release 2.1 needs-cherry-pick-release-3.0 Type: Need cherry pick to release 3.0 needs-cherry-pick-release-3.1 Type: Need cherry pick to release 3.1 needs-cherry-pick-release-4.0 Type: Need cherry pick to release 4.0 sig/coprocessor SIG: Coprocessor status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants