tidb_query: fix converting bytes to bool (#7486) #7547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
sig/coprocessor
|
@zhongzc Please help to fix the conflicts. Thanks! |
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
zhongzc
force-pushed
the
release-3.1-4175d681d9e0
branch
from
e59a435
to
f6dea4a
Compare
|
/run-all-tests |
|
/run-test |
|
/test |
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
breezewish
approved these changes
Apr 26, 2020
zhongzc
approved these changes
Apr 26, 2020
|
/merge |
|
/run-all-tests |
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
|
@youjiali1995 Conflict fixed. |
|
/merge |
|
/run-all-tests |
solotzg
added a commit
to pingcap/tidb-engine-ext
that referenced
this pull request
May 14, 2020
txn: only wake up waiters when locks are indeed released (tikv#7379) (tikv#7585) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com> txn: don't protect rollback for BatchRollback (tikv#7605) (tikv#7608) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com> tidb_query: add is true/false keep null ScalarFuncSig (tikv#7532) (tikv#7566) Signed-off-by: zhongzc <zhongzc_arch@outlook.com> tidb_query: fix the logical behavior of floats (tikv#7342) (tikv#7582) Signed-off-by: zhongzc <zhongzc_arch@outlook.com> tidb_query: fix converting bytes to bool (tikv#7486) (tikv#7547) Signed-off-by: zhongzc <zhongzc_arch@outlook.com> raftstore: change the condition of proposing rollback merge (tikv#6584) (tikv#7762) Signed-off-by: Liqi Geng <gengliqiii@gmail.com> Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #7486 to release-3.1
Signed-off-by: zhongzc zhongzc_arch@outlook.com
What problem does this PR solve?
Fix compatibility with MySQL.
See: pingcap/tidb#16014
What is changed and how it works?
Bytes is converted to an
f64type instead of an int type to determine the bool value.