copr: Add mysql Enum and Set support #8849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would recommend split this into several PRs. You may first add enum and set types, then implement chunk vectors, and finally modify other parts in copr. This way, we could move on really fast. |
|
OK |
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
changed the title
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
skyzh
reviewed
Oct 27, 2020
skyzh
reviewed
Oct 27, 2020
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
ping @skyzh, please review again~ |
breezewish
reviewed
Oct 27, 2020
Signed-off-by: Xuanwo <github@xuanwo.io>
skyzh
approved these changes
Oct 27, 2020
|
/run-all-tests |
breezewish
reviewed
Oct 27, 2020
|
/run-all-tests |
Signed-off-by: Xuanwo <github@xuanwo.io>
breezewish
approved these changes
Oct 28, 2020
ti-srebot
approved these changes
Oct 28, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: tikv/rfcs#57
What is changed and how it works?
Proposal: chunk-based enum and set support in coprocessor
This PR will add mysql enum and set support.
Check List
Tests