-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key and size threshold for load-base-split (#9256) #9354
Add key and size threshold for load-base-split (#9256) #9354
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@lhy1024 you're already a collaborator in bot's repo. |
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
/label do-not-merge/cherry-pick-not-approved |
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved (/lgtm + /merge) by the collaborators. AFTER it has been approved by collaborators, please send an email to the QA team requesting approval and the QA team will help you merge the PR. |
/lgtm cancel |
/label cherry-pick-approved |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d528fd6
|
@ti-srebot: Your PR has out-of-dated, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick tikv#9256 to release-4.0 --- <!-- Thank you for contributing to TiKV! If you haven't already, please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed If you want to open the **Challenge Program** pull request, please use the following template: https://raw.githubusercontent.com/tikv/.github/master/.github/PULL_REQUEST_TEMPLATE/challenge-program.md You can use it with query parameters: https://github.com/tikv/tikv/compare/master...${you branch}?template=challenge-program.md --> ### What problem does this PR solve? Issue Number: close tikv#9255 Problem Summary:: Add key and size threshold for load-base-split to avoid unnecessarily split ### What is changed and how it works? add threshold and unit test ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test ### Release note <!-- bugfixes or new feature need a release note -->
cherry-pick #9256 to release-4.0
What problem does this PR solve?
Issue Number: close #9255
Problem Summary::
Add key and size threshold for load-base-split to avoid unnecessarily split
What is changed and how it works?
add threshold and unit test
Check List
Tests
Release note