Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Folder in file selection menu will not exist if there's any non-ASCII character presents #22

Closed
knight-ryu12 opened this issue Jan 19, 2022 · 5 comments
Closed

[BUG] Folder in file selection menu will not exist if there's any non-ASCII character presents #22

knight-ryu12 opened this issue Jan 19, 2022 · 5 comments
Assignees
@tildearrow
Labels
bug Something isn't working done issue resolved GUI issues with the user interface
Milestone
0.4.6

Comments

@knight-ryu12
Copy link

knight-ryu12 commented Jan 19, 2022 •
edited
Loading

Seems that if there's any non-ASCII character in folder name, folder will disappear from directory listing.
@knight-ryu12
Copy link
Author

image

@tildearrow
Copy link
Owner

tildearrow commented Jan 19, 2022 •
edited
Loading

Hmmm.... looks like Unicode string handling issue on Windows (probs an issue with ImGuiFileDialog). I'll take a look at it soon.

@tildearrow tildearrow self-assigned this Jan 19, 2022
@tildearrow tildearrow added bug Something isn't working GUI issues with the user interface labels Jan 19, 2022
@freq-mod
Copy link
Collaborator

On Linux they are visible, except Japanese chars are replaced by question marks "?"

@tildearrow
Copy link
Owner

This issue will hopefully be solved in 0.4.6 as I have to release 0.4.5 now due to a crash bug.

@tildearrow tildearrow added this to the 0.4.6 milestone Jan 19, 2022
tildearrow added a commit that referenced this issue Jan 20, 2022
@tildearrow
dirent: use custom UTF-16 to UTF-8 converter
06dfb7e 
see issue #22
files/dirs with non-Latin chars are displayed after this commit
they still do not load though, but a fix is guaranteed
@tildearrow
Copy link
Owner

Fixed for 0.4.6.

@tildearrow tildearrow added the done issue resolved label Jan 20, 2022
@tildearrow tildearrow mentioned this issue Jan 21, 2022
Closed
Kagamiin pushed a commit to Kagamiin/furnace that referenced this issue Dec 31, 2023
@LTVA1
Merge pull request tildearrow#22 from LTVA1/icon-es5530
51155aa 
Icon for ES5530 instrument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tildearrow tildearrow

Labels
bug Something isn't working done issue resolved GUI issues with the user interface
Projects
None yet
Milestone
0.4.6
Development

No branches or pull requests
3 participants
@knight-ryu12 @tildearrow @freq-mod