This repository has been archived by the owner on Apr 4, 2019. It is now read-only.
[WIP] Rehydration #404
Open
[WIP] Rehydration #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 |
added 3 commits
August 18, 2015 16:28
This code path predates the existence of `blockFor`, which is a more
general-purpose and flexible mechanism for implementing Ember-style
“layouts” that `{{yield}}` to the block provided to a component.
This allows us to use a unified code path between rehydration and normal rendering. We also discovered that we don’t use `lastYielded.self` (it was an accidental holdover from the code that was refactored into lastYielded), so we removed it (along with a vestigial `shadowTemplate`, removed in a previous commit).
added 2 commits
August 18, 2015 17:40
This is important because we use empty text nodes as boundary nodes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR implements rehydration at the HTMLBars level.
There are a few things we need to do before we can consider the primitive level "complete":
templateId(done in db6462f)MorphListManualElement)