Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourcemaps only work for one file #5

Closed
knownasilya opened this issue Feb 8, 2018 · 3 comments · Fixed by #9
Closed

sourcemaps only work for one file #5

knownasilya opened this issue Feb 8, 2018 · 3 comments · Fixed by #9

Comments

@knownasilya
Copy link
Contributor

knownasilya commented Feb 8, 2018 •
edited
Loading

I have about 8 files in my project, but only one is sourcemapped

screen shot 2018-02-08 at 10 35 12 am

The guid file.
@knownasilya knownasilya mentioned this issue Feb 9, 2018
Closed
@sohara
Copy link

sohara commented Apr 9, 2018

👍 @chancancode This would be great to fix for in-browser debugging of tests, etc.

@sohara
Copy link

sohara commented Apr 30, 2018

@chancancode @wycats This can be reproduced on e.g. https://github.com/cross-check/schema/tree/0-9-upgrade with the following steps:

  • Run the tdd command
  • Visit the tests in the browser (e.g. chrome)
  • In dev tools use command-p (mac) to attempt to access source for a file that should be mapped by the source maps
  • See that in this case the only file that got mapped was schema/test/format.ts

chancancode added a commit that referenced this issue May 1, 2018
@chancancode
Fix browser sourcemaps (in dev/tdd mode)
0420ef7 
Previously, webpack was just bundling (concatenating, basically) all the
source files into one big file. This includes the `sourceMappingURL` at
the bottom of each file (emitted by typescript). Since the browser only
expect at most one such comment at the bottom of a file, it effectively
means that only the last file's source map get recognized by the
browser.

This fixes it using the Sourcemap Loader which extracts the input source
maps and re-emit them once after bundling.

The VSCode debug workflow was unaffected by this problem, since it uses
the commonjs build directly without using webpack to bundle them.

Fixes #5.
@chancancode chancancode mentioned this issue May 1, 2018
Merged
@chancancode
Copy link
Member

@knownasilya sorry it took so long, this should be fixed in v0.5.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix browser sourcemaps (in dev/tdd mode) tildeio/libkit
3 participants
@knownasilya @chancancode @sohara