Fix browser sourcemaps (in dev/tdd mode) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, webpack was just bundling (concatenating, basically) all the source files into one big file. This includes the `sourceMappingURL` at the bottom of each file (emitted by typescript). Since the browser only expect at most one such comment at the bottom of a file, it effectively means that only the last file's source map get recognized by the browser. This fixes it using the Sourcemap Loader which extracts the input source maps and re-emit them once after bundling. The VSCode debug workflow was unaffected by this problem, since it uses the commonjs build directly without using webpack to bundle them. Fixes #5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, webpack was just bundling (concatenating, basically) all the source files into one big file. This includes the
sourceMappingURLat the bottom of each file (emitted by typescript). Since the browser only expect at most one such comment at the bottom of a file, it effectively means that only the last file's source map get recognized by the browser.This fixes it using the Sourcemap Loader which extracts the input source maps and re-emit them once after bundling.
The VSCode debug workflow was unaffected by this problem, since it uses the commonjs build directly without using webpack to bundle them.
Fixes #5.