[BUGFIX] Query param plus symbols (+) are now transformed to spaces #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
@rwjblue Anything needed for a merge? Wanna get this upstream asap. |
machty
added a commit
that referenced
this pull request
Jan 22, 2015
[BUGFIX] Query param plus symbols (+) are now transformed to spaces
|
@machty thanks boo 💋 |
jayphelps
added a commit
to jayphelps/ember.js
that referenced
this pull request
Jan 22, 2015
rwjblue
added a commit
to emberjs/ember.js
that referenced
this pull request
Jan 22, 2015
Bumped sha to get tildeio/route-recognizer#40, which fixes #10190
rwjblue
added a commit
that referenced
this pull request
Jan 25, 2015
rwjblue
pushed a commit
to emberjs/ember.js
that referenced
this pull request
Jan 25, 2015
Conflicts: bower.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes emberjs/ember.js#10190
http://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.1
Facebook's share redirect masking is a great way to confirm this issue and behavior. (note that even query keys can have encoded spaces)
Cc/ @machty