Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a failing test for #82. #83

Closed
wants to merge 1 commit into from

Conversation

workmanw
Copy link
Contributor

If you comment out the addition of the star route, the test will pass. IE:

//  router.add([{ path: "/foo/:dynamic", handler: handler1 }, { path: "/*wildcard", handler: handlerWildcard }]);

Also, if you remove the trailing '/' route, the test will pass. IE:

// before:
router.add([{ path: "/foo/:dynamic", handler: handler1 }, { path: "/baz/:dynamic", handler: handler2 }, { path: "/", handler: handler3 }]);

// after:
router.add([{ path: "/foo/:dynamic", handler: handler1 }, { path: "/baz/:dynamic", handler: handler2 } ]);

@workmanw
Copy link
Contributor Author

This was cherry picked into the PR fixing the issue. Closing.

@workmanw workmanw closed this Jul 28, 2016
@jamesplease
Copy link
Contributor

✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants