Allow specifying a URL for planet instead of assuming the osm-pds S3 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zerebubuth or @rmarianski, do you have some time to look through these changes or are you busy? |
|
🎉 |
zerebubuth
reviewed
Aug 7, 2020
| echo "checking planet file MD5" > $STATUS | ||
| (cd planet && md5sum --check "${PLANET}.md5") | ||
| # check the md5sum if the md5 file was downloaded | ||
| if [[ -f "planet/${PLANET_FILE}.md5" ]]; then |
There was a problem hiding this comment.
Does this assume that ${PLANET_MD5_URL} = "${PLANET_URL}.md5"? Consequences aren't bad if not - it just skips the check, and it's a very strong convention to have the MD5 file be the original file + .md5. Maybe line 91 above could be wget -O "${PLANET_FILE}.md5" -q "${PLANET_MD5_URL}" to cover this (microscopic) corner case?
There was a problem hiding this comment.
Yea, good catch. I'll adjust this in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature to specify a URL to download from instead of calculating the URL to the
osm-pdsbucket using the "planet date" value. Specifying the--planet-urloption also makes MD5 checksumming optional. Add the--planet-md5-urlargument to download and use that file to checksum the planet downloaded with--planet-url.