Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add weir to water layer #1931

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add weir to water layer #1931

wants to merge 4 commits into from

Conversation

rwrx
Copy link
Contributor

@rwrx rwrx commented Sep 30, 2019 •
edited
Loading

Add weir to water layer

@nvkelso
Copy link
Member

nvkelso commented Sep 30, 2019 •
edited
Loading

We put dam in landuse layer, so weir should probably also go into landuse layer? But if a dam is a point we put it into pois layer, and we should do that as well. The min_zoom should vary if point or line... and we'd probably want to vary the min_zoom for lines depending on the length.

https://wiki.openstreetmap.org/wiki/Tag:waterway=weir

@rwrx
Copy link
Contributor Author

rwrx commented Oct 1, 2019

I have moved weir into landuse layer. I am not sure also how to add different zooms depending on the line length.

nvkelso
nvkelso reviewed Oct 7, 2019
View reviewed changes
spreadsheets/sort_rank/landuse.csv Outdated
@@ -21,6 +21,7 @@ dam,*,223
land,*,222
wetland,*,220
mud,*,219
weir,*,218
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this between breakwater and dam.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put weir between breakwater and dam.

@nvkelso nvkelso added this to the v1.9.0 milestone Nov 11, 2019
@rwrx rwrx mentioned this pull request Mar 21, 2022
Open
nvkelso
nvkelso reviewed Mar 21, 2022
View reviewed changes
yaml/landuse.yaml
- filter:
waterway: weir
geom_type: line
min_zoom: 12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 12 and not 13 or 14? In your style when do you show it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is used in our style which is similar to OpenTopoMap as OpenTopoMap shows this in lower zooms.

@nvkelso nvkelso modified the milestones: v1.9.0, v2.0.0 Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvkelso nvkelso nvkelso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rwrx @nvkelso