Skip to content

Commit

Permalink
Remove variant_ref
Browse files Browse the repository at this point in the history
It might cause a memory leak.

Issue: tiliado/nuvolaplayer#467

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
  • Loading branch information
jiri-janousek committed Sep 4, 2018
1 parent f0f9a96 commit 59340d4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 29 deletions.
1 change: 0 additions & 1 deletion src/glib/RpcRouter.vala
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ public class RpcRouter: GLib.Object {
token = {};
}
if (notification) {
variant_ref(parameters); // FIXME: Why is this necessary?
string? detail = null;
Variant data = null;
RpcNotification.get_detail_and_params(parameters, out detail, out data);
Expand Down
28 changes: 0 additions & 28 deletions src/glib/Variant.vala
Original file line number Diff line number Diff line change
Expand Up @@ -462,34 +462,6 @@ private void variant_dict_add_param(VariantBuilder dict_builder, string key, str
dict_builder.add("{smv}", param_key, param_value);
}

[CCode (cname="g_variant_ref")]
private extern Variant* g_variant_ref(Variant* variant);

[CCode (cname="g_variant_unref")]
private extern void g_variant_unref(Variant* variant);

/**
* Increase Variant reference if it is not null.
*
* @param variant Variant value to increase the reference of.
*/
public void variant_ref(Variant? variant)
{
if (variant != null)
g_variant_ref(variant);
}

/**
* Decrease Variant reference if it is not null.
*
* @param variant Variant value to decrease the reference of.
*/
public void variant_unref(Variant? variant)
{
if (variant != null)
g_variant_unref(variant);
}

/**
* Print variant as string
*
Expand Down

0 comments on commit 59340d4

Please sign in to comment.