Hack-fix SVG conversion for Arch Linux #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsvg-convert is broken on Arch Linux for unknown reasons and has remained so since before November 2015 (issue #180). The prior commit (64397c2) changes the resizing operation rsvg-convert uses to zooming (works identically to specifying dimensions as tested with rsvg-convert in Jessie), while this one allows specifying an arbitrary alternate converter, as long as it is compatible with rsvg-convert's syntax. As a final piece to the solution, I have altered the nuvola-app-*-git PKGBUILDs for Arch to specify lasem-render, which is included in [extra] on Arch and has been tested to produce properly working icons. [1] https://wiki.gnome.org/Projects/Lasem
|
I'm ok with allowing specifying alternate SVG converter, but I'm against converting dimensions to zooms. Since the source icons are not guaranteed to always have same size, zoom approach is fragile. I propose following solution:
Once this issue is resolved, I'll update script template and start pushing icon sets I have on my shelve. |
|
Submitted the requested script to tiliado-archives/nuvola-app-template#1 as a reasonable place to stage it out to the various integrations. Closing this and #13 (included in tiliado-archives/nuvola-app-template#1 for consolidation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the Makefile to use zooms instead of dimensions to convert the icons (tested as working with rsvg on Debian Jessie) and further allows specifying an alternate converter — on Arch, lasem-render uses the same syntax (for zooms, anyway — doesn't allow dimensions) and actually works, unlike rsvg-convert.
I am fine with maintaining this locally for Arch PKGBUILDs, if necessary, but I don't think there's any harm in adding it to the integrations (I've tried to avoid any such problems).
As with my other PR, this is a problem for all integrations: here is a gist with a patch that should apply cleanly to all of them (tested on google-play and owncloud-music).