Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths filter #5

Merged
merged 4 commits into from
Sep 9, 2014
Merged

Paths filter #5

merged 4 commits into from
Sep 9, 2014

Conversation

pablobm
Copy link

@pablobm pablobm commented Sep 8, 2014

I wanted to put my site on maintenance mode, but still have access to the admin interface. This pull request makes this possible.

Please note that I update Gemfile.lock, which looks like should have been updated on master, but wasn't. Is this correct?

@tilsammans
Copy link
Owner

@iainbeeston what exactly, is shocking?

@pablobm
Copy link
Author

pablobm commented Sep 9, 2014

@tilsammans Don't worry, he works with me and was joking. It's a reference to the title of the last commit. (In fact it's a comment on that commit specifically).

And I'd be shocked and appalled if I was him too!

@tilsammans
Copy link
Owner

@iainbeeston never mind, read your comment out of context ;)

Taking a look at this now!

@iainbeeston
Copy link

Sorry for the confusion!

@tilsammans tilsammans merged commit ea530a3 into tilsammans:master Sep 9, 2014
tilsammans added a commit that referenced this pull request Sep 9, 2014
Added a new "without+ configuration option to specify paths
that must be bypassed.

Thanks to @pablobm for the pull request.
Closes #5
@tilsammans
Copy link
Owner

Thanks for the contribution! I've opted to drop the built-in /assets filtering and leave everything in the hands of users. Any paths to be bypassed can be added to the new without option.

Since this breaks previous behaviour, I've released version 2.0.0 which will print a post-install message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants