Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting working directory of cmd_button #526

Closed
Tadimsky opened this issue Sep 8, 2023 · 2 comments
Closed

Setting working directory of cmd_button #526

Tadimsky opened this issue Sep 8, 2023 · 2 comments

Comments

@Tadimsky
Copy link

Tadimsky commented Sep 8, 2023

I'm using multiple Tiltfiles for multi-repo scenario. I run tilt up in the main service which conditionally includes the Tiltfile from other repos.

In one of the other repos, I'm using cmd_button but it is failing as it runs the command in the working directory of where tilt up was called.
I am running commands like yarn graphql-codegen that rely on files in the ./node_modules file of the other repo.

Is there a way to set the working directory of a cmd_button so that it operates either where the Tiltfile is that defined it (the other repo) or for us to explicitly set it as a relative path?

@nicks
Copy link
Member

nicks commented Sep 11, 2023

not currently, but we would accept a pr to take the dir as an argument

@nicks
Copy link
Member

nicks commented Dec 4, 2023

this got fixed in #532

@nicks nicks closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants