Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_resource: add Windows support #212

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Conversation

milas
Copy link
Contributor

@milas milas commented Aug 2, 2021

Replace local('basename ...') with os.path.basename()` so that
it's portable across platforms without needing GNU coreutils.

Fixes #211.

@milas milas requested review from nicks and landism August 2, 2021 15:11
Replace `local('basename ...') with `os.path.basename()` so that
it's portable across platforms without needing GNU coreutils.

Fixes #211.
@milas milas force-pushed the milas/git-resource-windows branch from 2477b84 to 6cc32b8 Compare August 2, 2021 15:12
@milas milas merged commit 56010b6 into master Aug 2, 2021
@milas milas deleted the milas/git-resource-windows branch August 2, 2021 15:51
@milas milas mentioned this pull request Aug 2, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git_resource does not work on Windows
2 participants