web: rename TabNav to ResourceNav and cut all the tab stuff (#4425)

web/src/HUD.tsx

@@ -19,11 +19,11 @@ import LogStore, { LogStoreProvider } from "./LogStore"
 import OverviewPane from "./OverviewPane"
 import OverviewResourcePane from "./OverviewResourcePane"
 import PathBuilder, { PathBuilderProvider } from "./PathBuilder"
+import { ResourceNavProvider } from "./ResourceNav"
 import ShareSnapshotModal from "./ShareSnapshotModal"
 import { SidebarPinContextProvider } from "./SidebarPin"
 import { SnapshotActionProvider } from "./snapshot"
 import SocketBar from "./SocketBar"
-import { OverviewNavProvider } from "./TabNav"
 import {
   ShowErrorModal,
   ShowFatalErrorModal,
@@ -261,13 +261,13 @@ export default class HUD extends Component<HudProps, HudState> {
       hudClasses.push("is-snapshot")
     }
 
-    let validateTab = (name: string) =>
+    let validateResource = (name: string) =>
       resources.some((res) => res.name === name)
     return (
       <tiltfileKeyContext.Provider value={view.tiltfileKey}>
         <SidebarPinContextProvider>
           <ReactOutlineManager>
-            <OverviewNavProvider validateTab={validateTab}>
+            <ResourceNavProvider validateResource={validateResource}>
               <div className={hudClasses.join(" ")}>
                 <AnalyticsNudge needsNudge={needsNudge} />
                 <SocketBar state={this.state.socketState} />
@@ -277,7 +277,7 @@ export default class HUD extends Component<HudProps, HudState> {
 
                 {this.renderOverviewSwitch()}
               </div>
-            </OverviewNavProvider>
+            </ResourceNavProvider>
           </ReactOutlineManager>
         </SidebarPinContextProvider>
       </tiltfileKeyContext.Provider>

web/src/OverviewResourcePane.stories.tsx

@@ -2,8 +2,8 @@ import React from "react"
 import { MemoryRouter } from "react-router"
 import LogStore, { LogStoreProvider } from "./LogStore"
 import OverviewResourcePane from "./OverviewResourcePane"
+import { ResourceNavProvider } from "./ResourceNav"
 import { SidebarPinMemoryProvider } from "./SidebarPin"
-import { OverviewNavProvider } from "./TabNav"
 import { nResourceView, tenResourceView, twoResourceView } from "./testdata"
 
 type Resource = Proto.webviewResource
@@ -30,12 +30,13 @@ function OverviewResourcePaneHarness(props: {
   let { name, view } = props
   let entry = name ? `/r/${props.name}/overview` : `/overview`
   let resources = view?.resources || []
-  let validateTab = (name: string) => resources.some((res) => res.name == name)
+  let validateResource = (name: string) =>
+    resources.some((res) => res.name == name)
   return (
     <MemoryRouter initialEntries={[entry]}>
-      <OverviewNavProvider validateTab={validateTab}>
+      <ResourceNavProvider validateResource={validateResource}>
         <OverviewResourcePane view={view} />
-      </OverviewNavProvider>
+      </ResourceNavProvider>
     </MemoryRouter>
   )
 }

web/src/OverviewResourcePane.test.tsx

@@ -6,7 +6,7 @@ import { ButtonLeftPill, FilterRadioButton } from "./OverviewActionBar"
 import OverviewResourcePane from "./OverviewResourcePane"
 import { NotFound } from "./OverviewResourcePane.stories"
 import OverviewResourceSidebar from "./OverviewResourceSidebar"
-import { OverviewNavProvider } from "./TabNav"
+import { ResourceNavProvider } from "./ResourceNav"
 import { oneResourceView } from "./testdata"
 import { appendLinesForManifestAndSpan } from "./testlogs"
 
@@ -38,9 +38,9 @@ describe("alert filtering", () => {
     let root = mount(
       <MemoryRouter initialEntries={["/"]}>
         <LogStoreProvider value={logStore}>
-          <OverviewNavProvider validateTab={() => true}>
+          <ResourceNavProvider validateResource={() => true}>
             <OverviewResourcePane view={view} />
-          </OverviewNavProvider>
+          </ResourceNavProvider>
         </LogStoreProvider>
       </MemoryRouter>
     )

web/src/OverviewResourcePane.tsx

@@ -5,11 +5,11 @@ import HeaderBar from "./HeaderBar"
 import { LogUpdateAction, LogUpdateEvent, useLogStore } from "./LogStore"
 import OverviewResourceDetails from "./OverviewResourceDetails"
 import OverviewResourceSidebar from "./OverviewResourceSidebar"
+import { useResourceNav } from "./ResourceNav"
 import StarredResourceBar, {
   starredResourcePropsFromView,
 } from "./StarredResourceBar"
 import { Color } from "./style-helpers"
-import { useTabNav } from "./TabNav"
 import { ResourceName } from "./types"
 
 type OverviewResourcePaneProps = {
@@ -34,10 +34,10 @@ let Main = styled.div`
 `
 
 export default function OverviewResourcePane(props: OverviewResourcePaneProps) {
-  let nav = useTabNav()
+  let nav = useResourceNav()
   const logStore = useLogStore()
   let resources = props.view?.resources || []
-  let name = nav.invalidTab || nav.selectedTab || ""
+  let name = nav.invalidResource || nav.selectedResource || ""
   let r: Proto.webviewResource | undefined
   let all = name === "" || name === ResourceName.all
   if (!all) {