web: rename TabNav to ResourceNav and cut all the tab stuff#4425
Merged
Conversation
nicks
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up a bunch of stuff that we no longer need now that we don't have tabs.
I went a bit down the path of just removing the concept of a nav context entirely, but this seems better than trying to get history + pathbuilder into everywhere that needs it, and is still a step in that direction if we decide to do that in the future.
The TabNav.tsx/ResourceNav.tsx edits are a separate commit in this branch, if you want to see the changes to that file (since the branch diff didn't detect it as a rename).