Skip to content

Commit

Permalink
engine: fix Pod span ID for PortForward objects (#4508)
Browse files Browse the repository at this point in the history
See #4498 - the signature changed here but didn't get rebased
before #4499 was merged, so wrong signature was being used.
  • Loading branch information
milas committed May 4, 2021
1 parent 8d9c103 commit aab3145
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/engine/portforward/subscriber.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (s *Subscriber) diff(ctx context.Context, st store.RStore) (toStart []portF
// Name of the manifest that this Port Forward corresponds to
// (we need this to route the logs correctly)
v1alpha1.AnnotationManifest: manifest.Name.String(),
v1alpha1.AnnotationSpanID: string(k8sconv.SpanIDForPod(podID)),
v1alpha1.AnnotationSpanID: string(k8sconv.SpanIDForPod(manifest.Name, podID)),
},
},
Spec: PortForwardSpec{
Expand Down

0 comments on commit aab3145

Please sign in to comment.