portforward: reimplement current port forward behavior with api objects [ch11953] #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
approved these changes
Apr 30, 2021
| Annotations: map[string]string{ | ||
| // Name of the manifest that this Port Forward corresponds to | ||
| // (we need this to route the logs correctly) | ||
| v1alpha1.AnnotationManifest: manifest.Name.String(), |
There was a problem hiding this comment.
it would probably also make sense to attach the AnnotationSpanId that's used below in PodLogActionWriter
milas
added a commit
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay I think this is a better version of #4483
As per @milas's proposed new migration plan, this is step 1:
In the next PR, I will
PortForwardReconcilersubscriber (which won't actually touch the API server yet will just read PF's off the EngineState)