Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the --watch flag for tilt up #3256

Closed
nicks opened this issue Apr 29, 2020 · 3 comments · Fixed by #3440
Closed

Remove the --watch flag for tilt up #3256

nicks opened this issue Apr 29, 2020 · 3 comments · Fixed by #3440
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nicks
Copy link
Member

nicks commented Apr 29, 2020 •
edited

tilt up has a flag --watch

Originally, --watch=false was the default. Tilt wouldn't watch any files or watch any Kubernetes resources.

We realized very early on that the default behavior should be --watch=true, because Tilt really should be watching your changes and telling you if your deployments have problems.

As we've added more features that only work if Tilt is watching Kubernetes (like resource_deps), the behavior of --watch=false doesn't really make sense. It's mostly obsoleted by tilt ci - see docs. We should just remove the --watch flag.
@nicks nicks added the enhancement New feature or request label Apr 29, 2020
@maiamcc maiamcc added the good first issue Good for newcomers label Jun 9, 2020
@abdullahzameek abdullahzameek self-assigned this Jun 11, 2020
@abdullahzameek abdullahzameek linked a pull request Jun 11, 2020 that will close this issue
Added Deprecate Property to Watch Flag (Issue #3256) #3440
Merged
@abdullahzameek abdullahzameek mentioned this issue Jun 11, 2020
Merged
@abdullahzameek abdullahzameek removed a link to a pull request Jun 11, 2020
Added Deprecate Property to Watch Flag (Issue #3256) #3440
Merged
abdullahzameek added a commit that referenced this issue Jun 12, 2020
@abdullahzameek
Added Deprecate Property to Watch Flag (Issue #3256) (#3440)
329e43f 
* added deprecate to watch flag

* added deprecate warning to logs

* fixed error, set check for watch flag properly

* fixed error, set check for watch flag properly

* logged warnign with Warnf
@nicks
Copy link
Member Author

nicks commented Jun 12, 2020

@abdullahzameek should we keep this open until the flag is removed?

@abdullahzameek
Copy link
Contributor

@abdullahzameek should we keep this open until the flag is removed?

Oh yeah, true. I forgot that linking the PR to the issue would close it once I merge the PR. Yep, I'll work on removing the flag when the time comes, so I'll re-open it!

@abdullahzameek abdullahzameek removed their assignment Aug 17, 2020
@milas
Copy link
Member

milas commented Dec 10, 2021

Watch flag was removed in #4320.

@milas milas closed this as completed Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Deprecate Property to Watch Flag (Issue #3256) tilt-dev/tilt
4 participants
@nicks @milas @maiamcc @abdullahzameek