Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Remove --watch=false flag, and update integration tests to not depend on it #4320

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 15, 2021

Hello @maiamcc, @landism,

Please review the following commits I made in branch nicks/watch:

a8331c3 (2021-03-15 18:59:13 -0400)
cli: Remove --watch=false flag, and update integration tests to not depend on it

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

Copy link
Member

@landism landism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👐

@nicks nicks merged commit 7b7cbc3 into master Mar 16, 2021
@nicks nicks deleted the nicks/watch branch March 16, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants