tiltfile: pass TILT_HOST + TILT_PORT to local() commands #4773
Conversation
Various Tilt extensions have been using `local()` to shell back out to Tilt to use the API (e.g. `tilt apply -f ...`). This does not play nice with custom ports if Tilt was invoked using the `--port` argument. Now, the current Tilt instance's port is passed as the `TILT_PORT` argument so that the invoked command will automatically connect to the same instance of Tilt.
internal/tiltfile/files.go
Outdated
| // if Tilt was invoked with `tilt up --port=XXXXX`, local() calls to use the Tilt API will fail due to trying to | ||
| // connect to the default port, so explicitly populate the TILT_PORT environment variable if it isn't already | ||
| hasTiltPort := false | ||
| for _, e := range c.Env { |
There was a problem hiding this comment.
it might make sense to do this in PrepareEnv with the other Env injections?
https://github.com/tilt-dev/tilt/blob/master/pkg/logger/env.go#L19
though I guess you'd have do pass webport to that function...
There was a problem hiding this comment.
Yeah I thought about that but it seemed weird since that's logger.PrepareEnv and pretty specific to xterm type stuff.
I (very briefly) looked at doing it in Execer and having local() use that but Execer is way more oriented to use for the BaDer for daemons and it seemed more headache/risky than it was worth. I think maybe the right thing in the future is to replace the pure localexec.ExecCmd with a struct that does the preparation so that it can hold state of things to inject (bonus: you also wouldn't need to pass a logger every time).
milas
changed the title
Various Tilt extensions have been using
local()to shell backout to Tilt to use the API (e.g.
tilt apply -f ...). This doesnot play nice with custom ports if Tilt was invoked using the
--portargument.Now, the current Tilt instance's port is passed as the
TILT_PORTargument so that the invoked command will automatically connect to
the same instance of Tilt.
Fixes #4737.