Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiltfile: pass TILT_HOST + TILT_PORT to local() commands #4773

Merged
merged 4 commits into from
Jul 19, 2021
Merged

tiltfile: pass TILT_HOST + TILT_PORT to local() commands #4773

merged 4 commits into from
Jul 19, 2021

Commits on Jul 19, 2021

  1. tiltfile: pass TILT_PORT to local() commands 

    Various Tilt extensions have been using `local()` to shell back
out to Tilt to use the API (e.g. `tilt apply -f ...`). This does
not play nice with custom ports if Tilt was invoked using the
`--port` argument.

Now, the current Tilt instance's port is passed as the `TILT_PORT`
argument so that the invoked command will automatically connect to
the same instance of Tilt.
    @milas
    milas committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    7035ee9 View commit details
    Browse the repository at this point in the history

  2. tiltfile: also pass TILT_HOST to local() cmds

    @milas
    milas committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    f3d9caa View commit details
    Browse the repository at this point in the history

  3. test: use command_bat for windows variant

    @milas
    milas committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    03baf83 View commit details
    Browse the repository at this point in the history

  4. test: fix test closure so correct failing test is reported

    @milas
    milas committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    9db2990 View commit details
    Browse the repository at this point in the history