Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs: also store trigger queue reasons in the apiserver #4921

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Sep 2, 2021

Hello @milas,

Please review the following commits I made in branch nicks/triggerqueue:

9f0907f (2021-09-02 17:25:37 -0400)
configs: also store trigger queue reasons in the apiserver

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's worth renaming the other keys as well, e.g. %d-name or something so that the pattern is consistent. (That said, it's pretty straight-forward as-is.)

@nicks
Copy link
Member Author

nicks commented Sep 2, 2021

sure, that seems reasonable to me. done!

@nicks nicks merged commit 8a037e7 into master Sep 3, 2021
@nicks nicks deleted the nicks/triggerqueue branch September 3, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants