Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: add a load event for expand/collapse #5219

Merged
merged 1 commit into from
Nov 24, 2021
Merged

web: add a load event for expand/collapse #5219

merged 1 commit into from
Nov 24, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Nov 23, 2021

Hello @lizzthabet, @landism,

Please review the following commits I made in branch nicks/onload:

9622b3f (2021-11-23 16:28:57 -0500)
web: add a load event for expand/collapse
intended to mirror the similar load event for star/unstar

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

intended to mirror the similar load event for star/unstar
@nicks nicks merged commit ac711d0 into master Nov 24, 2021
@nicks nicks deleted the nicks/onload branch November 24, 2021 17:11
nicks added a commit that referenced this pull request Nov 24, 2021
nicks added a commit that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants