Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "web: add a load event for expand/collapse (#5219)" #5227

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Nov 24, 2021

Hello @nicks,

Please review the following commits I made in branch nicks/revert:

665aa44 (2021-11-24 15:06:19 -0500)
Revert "web: add a load event for expand/collapse (#5219)"
This reverts commit ac711d0.

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
Copy link
Member Author

nicks commented Nov 24, 2021

this doesn't work correctly, because to collapse/expand context doesn't do anything to reconcile the groups that exist with the groups in the store.

@nicks nicks merged commit b6b49d4 into master Nov 24, 2021
@nicks nicks deleted the nicks/revert branch November 24, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant