session: ensure 'tilt ci' exits properly when reattaching to jobs #6276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/issue6272
branch
from
dc5e529
to
e8aa586
Compare
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
fixes tilt-dev#6272 History of this change: - we used to have a very naive definition of "Ready" - callers of the runtime status API had hacks to look at Job pods to determine completeness (tilt-dev#4367) - later, we changed it to have a more sophisticated definition, so that Jobs only count as 'ready' when they're complete. (tilt-dev#5013) - we forgot to remove the old caller hacks :grimace: in any case, i added a bunch of tests, since we need more job integration tests anyway. Signed-off-by: Nick Santos <nick.santos@docker.com>
nicks
force-pushed
the
nicks/issue6272
branch
from
e8aa586
to
4d02ced
Compare
|
cc @dnephin |
dnephin
approved these changes
Dec 6, 2023
Comment on lines
+435
to
+442
| krs.HasEverDeployedSuccessfully = true | ||
| // There are no pods but the job completed successfully. | ||
| krs.Conditions = []metav1.Condition{ | ||
| { | ||
| Type: v1alpha1.ApplyConditionJobComplete, | ||
| Status: metav1.ConditionTrue, | ||
| }, | ||
| } |
There was a problem hiding this comment.
I think some or all of these lines are no longer necessary for the test to pass (but I haven't actually confirmed that by trying it).
Suggested change
| krs.HasEverDeployedSuccessfully = true | |
| // There are no pods but the job completed successfully. | |
| krs.Conditions = []metav1.Condition{ | |
| { | |
| Type: v1alpha1.ApplyConditionJobComplete, | |
| Status: metav1.ConditionTrue, | |
| }, | |
| } |
There was a problem hiding this comment.
nope! these fields are used to infer runtime state, see
tilt/internal/store/runtime_state.go
Line 136 in 01b9ea6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6272
History of this change:
in any case, i added a bunch of tests, since we need more job integration tests anyway.