Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: ensure 'tilt ci' exits properly when reattaching to jobs #6276

Merged
merged 2 commits into from
Dec 8, 2023
Merged

session: ensure 'tilt ci' exits properly when reattaching to jobs #6276

merged 2 commits into from
Dec 8, 2023

Commits on Dec 5, 2023

  1. Handle jobs with deleted pods 

    Signed-off-by: Daniel Nephin <dnephin@gmail.com>
    @dnephin @nicks
    dnephin authored and nicks committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    99c47ee View commit details
    Browse the repository at this point in the history

  2. session: ensure 'tilt ci' exits properly when reattaching to jobs 

    fixes tilt-dev#6272

History of this change:
- we used to have a very naive definition of "Ready"
- callers of the runtime status API had hacks to look at Job pods to determine completeness (tilt-dev#4367)
- later, we changed it to have a more sophisticated definition, so that
  Jobs only count as 'ready' when they're complete. (tilt-dev#5013)
- we forgot to remove the old caller hacks :grimace:

in any case, i added a bunch of tests, since we need more job integration tests anyway.

Signed-off-by: Nick Santos <nick.santos@docker.com>
    @nicks
    nicks committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    4d02ced View commit details
    Browse the repository at this point in the history