Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GET requests #1

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

jontysponselee
Copy link

@jontysponselee jontysponselee commented Mar 23, 2017

Added GET requests for organization:

  • Organization
  • OrganizationList
  • OrganizationInfoList
  • OrganizationStateNVL
  • OrganizationNVL
  • OrganizationDocumentsOutput

Added GET requests for product:

  • Product
  • ProductDiscountGroupNVl
  • ProductGroup
  • ProductGroupRelationInfo
  • ProductNVL

Added GET requests for company:

  • CompanyDetails
  • CompanyDetailsInfo

Added GET requests for Warehouse:

  • Warehouse
  • WarehouseNVL

Added GET requets for order:

  • OrderChargeVatTypeNVL

Added GET requests for address:

  • Address
  • AddressList
  • AddressInfo
  • AddressInfoList
  • AddressTypeNVL

Added GET requests for product:

  • ProductInfo

Added GET request for Administration:

  • AdministrationInfo
  • AdministrationGroup
  • AdministrationNVL
  • AdministrationGroupNVL

Added GET request for Customer:

  • CustomerGroupInfo
  • CustomerGroupInfoList
  • CustomerGroupNVL
  • CustomerInfoList
  • CustomerInfo
  • Customer
  • CustomerChargeVatTypeNVL
  • CustomerNVL
  • CustomerPersonNVL

@jontysponselee jontysponselee changed the title Organization GET requests Organization/ Address GET requests Mar 23, 2017
@jontysponselee jontysponselee changed the title Organization/ Address GET requests Added GET requests Mar 24, 2017
@LeonB
Copy link
Contributor

LeonB commented Apr 25, 2017

@infinityart je code bevat character returns (\r). Zorg even dat die goed staan (\n).

Daarnaast geeft go vet de volgende resultaten:

$ go vet
mail_template.go:6: struct field canChange has json tag but is not exported
oauth.go:149: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
organization_nvl.go:27: unreachable code
product_info.go:53: struct field tag `json:priceInclVat` not compatible with reflect.StructTag.Get: bad syntax for struct tag value
product_supplier.go:12: struct field productSupplierID has json tag but is not exported

Daarnaast krijg ik van go lint:

$ golint | grep -v "should have comment"
address.go:50:2: struct field CountryId should be CountryID
address.go:54:2: struct field LanguageId should be LanguageID
address.go:56:2: struct field OrganizationId should be OrganizationID
address_info.go:49:2: struct field GoogleMapsDirectionsUrl should be GoogleMapsDirectionsURL
address_info.go:50:2: struct field GoogleMapsUrl should be GoogleMapsURL
administration_group_nvl.go:19:1: comment on exported method AdministrationGroupNVLService.Get should be of the form "Get ..."
administration_nvl.go:20:36: method GetByGroupIdAndUsername should be GetByGroupIDAndUsername
administration_nvl.go:46:36: method GetByGroupId should be GetByGroupID
customer.go:60:2: struct field CustomerGroupId should be CustomerGroupID
customer.go:72:2: struct field GoogleMapsDirectionsUrl should be GoogleMapsDirectionsURL
customer.go:73:2: struct field GoogleMapsUrl should be GoogleMapsURL
organization.go:61:2: struct field GoogleMapsDirectionsUrl should be GoogleMapsDirectionsURL
organization.go:62:2: struct field GoogleMapsUrl should be GoogleMapsURL
organization_documents_output.go:46:2: struct field OrganizationId should be OrganizationID
product.go:69:2: struct field ProductDiscountGroupId should be ProductDiscountGroupID
product.go:70:2: struct field ProductGroupId should be ProductGroupID
product.go:71:2: struct field ProductId should be ProductID
product.go:85:2: struct field VatCodeId should be VatCodeID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants