-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GET requests #1
Open
jontysponselee
wants to merge
48
commits into
tim-online:master
Choose a base branch
from
jontysponselee:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jontysponselee
changed the title
Organization GET requests
Organization/ Address GET requests
Mar 23, 2017
…ates is in mail_template.go
@infinityart je code bevat character returns (\r). Zorg even dat die goed staan (\n). Daarnaast geeft go vet de volgende resultaten: $ go vet
mail_template.go:6: struct field canChange has json tag but is not exported
oauth.go:149: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
organization_nvl.go:27: unreachable code
product_info.go:53: struct field tag `json:priceInclVat` not compatible with reflect.StructTag.Get: bad syntax for struct tag value
product_supplier.go:12: struct field productSupplierID has json tag but is not exported Daarnaast krijg ik van go lint: $ golint | grep -v "should have comment"
address.go:50:2: struct field CountryId should be CountryID
address.go:54:2: struct field LanguageId should be LanguageID
address.go:56:2: struct field OrganizationId should be OrganizationID
address_info.go:49:2: struct field GoogleMapsDirectionsUrl should be GoogleMapsDirectionsURL
address_info.go:50:2: struct field GoogleMapsUrl should be GoogleMapsURL
administration_group_nvl.go:19:1: comment on exported method AdministrationGroupNVLService.Get should be of the form "Get ..."
administration_nvl.go:20:36: method GetByGroupIdAndUsername should be GetByGroupIDAndUsername
administration_nvl.go:46:36: method GetByGroupId should be GetByGroupID
customer.go:60:2: struct field CustomerGroupId should be CustomerGroupID
customer.go:72:2: struct field GoogleMapsDirectionsUrl should be GoogleMapsDirectionsURL
customer.go:73:2: struct field GoogleMapsUrl should be GoogleMapsURL
organization.go:61:2: struct field GoogleMapsDirectionsUrl should be GoogleMapsDirectionsURL
organization.go:62:2: struct field GoogleMapsUrl should be GoogleMapsURL
organization_documents_output.go:46:2: struct field OrganizationId should be OrganizationID
product.go:69:2: struct field ProductDiscountGroupId should be ProductDiscountGroupID
product.go:70:2: struct field ProductGroupId should be ProductGroupID
product.go:71:2: struct field ProductId should be ProductID
product.go:85:2: struct field VatCodeId should be VatCodeID |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GET requests for organization:
Added GET requests for product:
Added GET requests for company:
Added GET requests for Warehouse:
Added GET requets for order:
Added GET requests for address:
Added GET requests for product:
Added GET request for Administration:
Added GET request for Customer: