Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image convert to webp #1638

Merged
merged 4 commits into from
Sep 6, 2018
Merged

Add image convert to webp #1638

merged 4 commits into from
Sep 6, 2018

Conversation

mhz-tamb
Copy link
Contributor

Ticket: #

Issue

Using images lighter than jpg

Solution

Allows to convert images to webp like tojpg

Impact

None

Usage Changes

Added a simple example in the documentation

Considerations

Testing

Tests are included, and run without problems

@coveralls
Copy link

coveralls commented Jan 13, 2018

Coverage Status

Coverage increased (+0.007%) to 94.203% when pulling 1d2795f on mhz-tamb:webp into 758c6db on timber:master.

@mhz-tamb
Copy link
Contributor Author

Hello! Do I need any changes?
In travis my tests break down. I think this is related to this issue travis-ci/travis-ci#8435
Will this be ok if I check the existence of the imagewebp function in the tests for skip it?

@pascalknecht
Copy link
Contributor

Any updates on this PR?

@jarednova jarednova self-requested a review July 9, 2018 20:34
@jarednova
Copy link
Member

@mhz-tamb @pascalknecht — thanks for your patience! I just got back last week from a paternity leave and this PR is next on my plate

jarednova added a commit that referenced this pull request Jul 10, 2018
@jarednova
Copy link
Member

@mhz-tamb @pascalknecht thanks again for the PR and your patience. As @mhz-tamb points out there is a Travis limitation on testing for webp — that said, things pass for me locally. I want to make sure we account for webp in the future, so here are two possible mitigations:

  1. Using the guidance of #8435 figure out how to enable imagewebp in the PHP Travis build we're using
  2. Skip the tests if imagewebp is not available.

@mhz-tamb — can you pick things back up from here?

@pascalknecht pascalknecht mentioned this pull request Sep 4, 2018
@jarednova jarednova merged commit 1d2795f into timber:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants