-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebP Support #1777
WebP Support #1777
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1777 +/- ##
============================================
- Coverage 94.91% 94.26% -0.66%
- Complexity 1526 1535 +9
============================================
Files 48 49 +1
Lines 3581 3607 +26
============================================
+ Hits 3399 3400 +1
- Misses 182 207 +25
Continue to review full report at Codecov.
|
@jarednova What do I need to do to get this merged? It is clear that the code coverage drops if I don't run the unit tests of the WebP Class as it is not supported. Only way to support it would be to install ImageMagick and that would probably further slow down the tests. Any opinion? |
Thanks @pascalknecht for bringing this to the finish line. I made a few small tweaks in #1780 based on what you submitted... Removed the unlinks —. Even though this is "neater", it's helpful to manually see the files generated during the tests to further verify the correct output. If we're going to do the unlinks (which a future 🌲 god might believe) lets apply it across the test suite: PNGs, JPGs and GIFs too) |
New version of #1638.
Improvements: