Add PHP 8.0/8.1 to Timber 1.x matrix

[nlemoine]

Related:

• PHP 8.0 Deprecation Warning #2580
• PHP8.1 | Deprecated: Return type compatibility #2548

[gchtr]

@nlemoine Thanks a lot for taking this on. Now, what do we need to move this out of draft status?

[nlemoine]

Hey @gchtr

I had some weird issues running tests (some "segmentation fault" with no valuable message). I solved them and finally almost fixed the tests. As you can see, some pass, some don't :

• PHP 7.4 | WP latest (MS) : some problems with the WP-CLI cache clearing
• PHP 7.4 | WP latest (with coverage) : I don't get why the clover file isn't readable, I didn't try much

Would you be interested to take this PR over?

[coveralls]

Coverage increased (+0.8%) to 93.049% when pulling 50f4b10 on 1.x-add-php-8-matrix into 8d9bff2 on master.

[gchtr]

@nlemoine I think this is ready now. I added some fixes for PHP 8.1 deprecation warnings, e.g. when cropping images without rounding the new width and height first.

And I found the fix for the missing clover.xml file in a7fdf59 (#2638).

There’s still a couple of warnings, but they are mostly related to WordPress itself, where we have no control.

Just need a final approval so we can merge this in.

[nlemoine]

Good job @gchtr!

[jarednova]

@gchtr @nlemoine I confirmed that the tests all pass with the merge of #2640. I was able to do a brief review of the code and new testing elements and am so humbled by how much cleaner and more sophisticated this leaves things. Lots of green checks!!!!