Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scheme detection and take advantage of WP native functions #2720

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Improve scheme detection and take advantage of WP native functions #2720

merged 1 commit into from
Mar 17, 2023

Conversation

nlemoine
Copy link
Member

@nlemoine nlemoine commented Mar 8, 2023

Using is_ssl:

  • covers more use cases than self made functions
  • is already there

@coveralls
Copy link

Coverage Status

Coverage: 88.609%. Remained the same when pulling d9f7ad6 on 2.x-better-scheme-detection into 3ac8aca on 2.x.

gchtr
gchtr approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@gchtr gchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@gchtr gchtr added the 2.0 label Mar 17, 2023
@nlemoine nlemoine merged commit 316bf64 into 2.x Mar 17, 2023
@Levdbas Levdbas deleted the 2.x-better-scheme-detection branch November 9, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchtr gchtr gchtr approved these changes

@jarednova jarednova Awaiting requested review from jarednova jarednova is a code owner

Assignees
No one assigned
Labels
2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlemoine @coveralls @gchtr