Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(statsd sink): Fix statsd binding to loopback only #1316

Merged
merged 1 commit into from
Dec 5, 2019
Merged

fix(statsd sink): Fix statsd binding to loopback only #1316

merged 1 commit into from
Dec 5, 2019

Conversation

loony-bean
Copy link
Contributor

Closes #1312

@loony-bean
Fix statsd binding to loopback only
e66f974 
Signed-off-by: Alexey Suslov <alexey.suslov@gmail.com>
@danpalmer
Copy link
Contributor

Ha you beat me to this PR! I was just testing this locally.

I can confirm that this fixes the issue for us though! Can't wait for this to ship.

lukesteensen
lukesteensen approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@lukesteensen lukesteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@lukesteensen lukesteensen merged commit 58d6e97 into master Dec 5, 2019
@lukesteensen lukesteensen deleted the metrics-statsd-bind branch December 5, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpalmer danpalmer danpalmer approved these changes

@lukesteensen lukesteensen lukesteensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(?): "Invalid argument" when emitting datagrams on statsd sink
3 participants
@loony-bean @danpalmer @lukesteensen