Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(splunk_hec sink)!: Add a new option for specifying indexed fields to splunk_hec sink #1537

Merged
6 commits merged into from
Jan 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2020

Closes #1534.

The option is added only to json encoding, as text encoding was not using fields previously.

I decided to not implement dropping the indexed fields from events mentioned in #1534 for now as I'm worried about unexpected results for existing users. It can be easily changed.

Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost ghost force-pushed the splunk-indexed-fields branch from 8d15063 to cf7ac69 Compare January 17, 2020 18:53
Signed-off-by: binarylogic <bjohnson@binarylogic.com>
Copy link
Contributor

@binarylogic binarylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good

Copy link
Member

@lukesteensen lukesteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/event/unflatten.rs Outdated Show resolved Hide resolved
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
…to splunk-indexed-fields

Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost ghost merged commit d0aba1b into master Jan 20, 2020
@ghost ghost deleted the splunk-indexed-fields branch January 20, 2020 12:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new option for specifying indexed fields to splunk_hec sink
3 participants