enhancement(dependencies): move reqwest to dev-dependencies #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
fanatid
added
type: tech debt
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
bruceg
requested changes
Jul 5, 2020
Comment on lines
+388
to
+404
| // It usually takes ~1 second for the event to show up in search, so poll until | ||
| // we see it. | ||
| async fn find_entry(message: &str) -> serde_json::value::Value { | ||
| let value = Some(message); | ||
| for _ in 0..20usize { | ||
| match recent_entries(None) | ||
| .await | ||
| .into_iter() | ||
| .find(|entry| entry["message"].as_str() == value) | ||
| { | ||
| Some(value) => return value, | ||
| None => std::thread::sleep(std::time::Duration::from_millis(100)), | ||
| } | ||
| } | ||
| panic!("Didn't find event in Splunk"); | ||
| } | ||
|
|
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
|
@bruceg thanks for checking! Fixed. |
bruceg
approved these changes
Jul 6, 2020
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
) * enhancement(dependencies): move reqwest to dev-dependencies Signed-off-by: Kirill Fomichev <fanatid@ya.ru> * update to new reqwest Signed-off-by: Kirill Fomichev <fanatid@ya.ru> * fix docker feature Signed-off-by: Kirill Fomichev <fanatid@ya.ru> * remove http:0.1 Signed-off-by: Kirill Fomichev <fanatid@ya.ru> * remove headers:02 Signed-off-by: Kirill Fomichev <fanatid@ya.ru> * fix clickhouse tests Signed-off-by: Kirill Fomichev <fanatid@ya.ru> * minor fixes Signed-off-by: Kirill Fomichev <fanatid@ya.ru> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwesttodev-dependenciesreqwesthttp:0.1crateheaders:0.2crateClose #2782